Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8194 )
Change subject: java: replace bespoke minicluster implementation with control shell ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/8194/6/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/8194/6/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@230 PS6, Line 230: .setStartDaemon(StartDaemonRequestPB.newBuilder().setId(d.id).build()) > use spaces here and elsewhere. Whoops, I forgot to import the GSG style when I upgraded Eclipse, sorry. http://gerrit.cloudera.org:8080/#/c/8194/6/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@417 PS6, Line 417: public String getTserverAddresses() { > This doesn't seem very useful, could it be removed? Although this isn't used, getTserverHostPorts() does have two callers and I figured that, like getMasterAddresses/getMasterHostPorts, it'd be useful to provide both variants for consistency. http://gerrit.cloudera.org:8080/#/c/8194/6/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@457 PS6, Line 457: * Copied from {@link ProtobufHelper} to work around gradle's broken test shading. > Could you file a JIRA / add a TODO? Filed KUDU-2186, will link here. -- To view, visit http://gerrit.cloudera.org:8080/8194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6340dadd6ff0397fffa23388a8cbbca3e26a618 Gerrit-Change-Number: 8194 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Comment-Date: Mon, 09 Oct 2017 23:51:03 +0000 Gerrit-HasComments: Yes
