Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8194 )
Change subject: java: replace bespoke minicluster implementation with control shell ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8194/6/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/8194/6/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@417 PS6, Line 417: public String getTserverAddresses() { > Although this isn't used, getTserverHostPorts() does have two callers and I Comma separated master addresses are used as a flag/configuration value routinely. I'm unaware of anything that uses a comma separated list of tablet servers, nor do I think we should encourage it. -- To view, visit http://gerrit.cloudera.org:8080/8194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6340dadd6ff0397fffa23388a8cbbca3e26a618 Gerrit-Change-Number: 8194 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 10 Oct 2017 00:56:18 +0000 Gerrit-HasComments: Yes
