Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8251 )

Change subject: tsan: flush TSAN memory every 10 seconds
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8251/1/build-support/run-test.sh
File build-support/run-test.sh:

http://gerrit.cloudera.org:8080/#/c/8251/1/build-support/run-test.sh@106
PS1, Line 106: history_size=7
Would it make sense to reduce it down to 5 (i.e. 1M accesses)?


http://gerrit.cloudera.org:8080/#/c/8251/1/build-support/run-test.sh@109
PS1, Line 109: flush_memory_ms
Maybe, dynamically setting memory_limit_mb option to some value based on 
/proc/meminfo would be a better alternative?  Or just set it to some constant 
and refuse to run if current available memory is less than the limit set?



--
To view, visit http://gerrit.cloudera.org:8080/8251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I721f126eb731c7f35afb732cebe48abd52c3ebd1
Gerrit-Change-Number: 8251
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 12 Oct 2017 22:08:09 +0000
Gerrit-HasComments: Yes

Reply via email to