Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8251 )
Change subject: tsan: flush TSAN memory every 10 seconds ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/8251/1/build-support/run-test.sh File build-support/run-test.sh: http://gerrit.cloudera.org:8080/#/c/8251/1/build-support/run-test.sh@106 PS1, Line 106: history_size=7 > I believe we set this to 7 because we were previously getting various error Ah, than makes sense. I didn't realize it was set to 4M was set after experiencing issues with lost history. http://gerrit.cloudera.org:8080/#/c/8251/1/build-support/run-test.sh@109 PS1, Line 109: flush_memory_ms > One issue with that is that we typically fork out several processes from a I'm not sure that setting _both_ memory_limit_mb and flush_memory_ms would buy us much: some extra-flushes, when the memory limit is not yet reached, might be just useless extra activity. But I might be missing something. Yep, ExternalMiniCluster might set those env variables according to the number of processes it starts, but it kind of messy -- I agree. If we don't want ExternalMiniCluster to be aware of those TSAN variables, maybe just setting flush_memory_ms is the best option. -- To view, visit http://gerrit.cloudera.org:8080/8251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I721f126eb731c7f35afb732cebe48abd52c3ebd1 Gerrit-Change-Number: 8251 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 13 Oct 2017 00:11:53 +0000 Gerrit-HasComments: Yes
