Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8227 )
Change subject: [webui] Add templates for master web ui. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@94 PS2, Line 94: Substit std::to_string() should work here http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@123 PS2, Line 123: has_no_live_ts = desc->PresumedDead() && has_no_live_ts; : has_no_dead_ts = !desc->PresumedDead() && has_no_dead_ts can use &= here http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@126 PS2, Line 126: (*output)["has_no_live_ts"] = "true"; : if (has_no_dead_ts) (*output)["has_no_dead_ts"] = "true"; how about using = std::to_string(has_no_live_ts)? would something like that work? we must have some nice way to do a bool-to-string -- To view, visit http://gerrit.cloudera.org:8080/8227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4520261dd617a160da51cdd089f42f078a0da728 Gerrit-Change-Number: 8227 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 13 Oct 2017 00:23:00 +0000 Gerrit-HasComments: Yes
