Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8257 )
Change subject: thread: improve performance of starting threads ...................................................................... Patch Set 4: (1 comment) oops, missed one! http://gerrit.cloudera.org:8080/#/c/8257/2/src/kudu/util/thread-test.cc File src/kudu/util/thread-test.cc: http://gerrit.cloudera.org:8080/#/c/8257/2/src/kudu/util/thread-test.cc@123 PS2, Line 123: std::vector<scoped_refptr<Thread>> threads(1000); > ~Thread doesn't Join(), so shouldn't we explicitly join at the end of the t Done -- To view, visit http://gerrit.cloudera.org:8080/8257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ce7f409ed33548142d1180c9f9653a8f51a7879 Gerrit-Change-Number: 8257 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 13 Oct 2017 01:11:46 +0000 Gerrit-HasComments: Yes
