Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8268 )
Change subject: Miscellaneous cleanup ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8268/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8268/1/src/kudu/master/catalog_manager.cc@1350 PS1, Line 1350: s = Status::AlreadyPresent(Substitute("New table name $0 is already reserved", req.name())); > ServiceUnavailable was probably chosen to get "free" retry behavior. Do we Yeah I think you're right. The operative retry loop is here: https://github.com/apache/kudu/blob/master/src/kudu/client/client-internal.cc#L198-L290. I added a comment to make it more obvious for future me's. http://gerrit.cloudera.org:8080/#/c/8268/1/src/kudu/master/catalog_manager.cc@1350 PS1, Line 1350: s = Status::AlreadyPresent(Substitute("New table name $0 is already reserved", req.name())); : return SetError(MasterErrorPB::TABLE_ALREADY_PRESENT, s > nit: it might be just I ended up rolling this back per Adar's comment. -- To view, visit http://gerrit.cloudera.org:8080/8268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94a1f5d476d30a959a056040b3eb30dfebcc9378 Gerrit-Change-Number: 8268 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 13 Oct 2017 17:42:56 +0000 Gerrit-HasComments: Yes
