Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8268 )
Change subject: Miscellaneous cleanup ...................................................................... Patch Set 3: (2 comments) Could you loop master-test 1000 times to make sure those TestConcurrentFoo tests are all good? http://gerrit.cloudera.org:8080/#/c/8268/3/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/8268/3/src/kudu/master/master-test.cc@1162 PS3, Line 1162: // 2. This thread lost the CreateTable() race, but the table is still Can you double check with the C++/Java clients that this doesn't break backwards compatibility? I would imagine they don't really care about the particular MasterErrorPB, but I'm not sure. http://gerrit.cloudera.org:8080/#/c/8268/3/src/kudu/master/master-test.cc@1172 PS3, Line 1172: CHECK(s.IsServiceUnavailable() || s.IsAlreadyPresent()) << failure_msg; Nit: fix indentation here and on L1174. -- To view, visit http://gerrit.cloudera.org:8080/8268 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94a1f5d476d30a959a056040b3eb30dfebcc9378 Gerrit-Change-Number: 8268 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 13 Oct 2017 22:59:02 +0000 Gerrit-HasComments: Yes
