Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8278 )
Change subject: [raft_consensus-itest] separate Raft election tests ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8278/1/src/kudu/integration-tests/raft_consensus-election-itest.cc File src/kudu/integration-tests/raft_consensus-election-itest.cc: http://gerrit.cloudera.org:8080/#/c/8278/1/src/kudu/integration-tests/raft_consensus-election-itest.cc@77 PS1, Line 77: using std::vector; > warning: using decl 'unordered_map' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/8278/1/src/kudu/integration-tests/raft_consensus-itest-base.h File src/kudu/integration-tests/raft_consensus-itest-base.h: http://gerrit.cloudera.org:8080/#/c/8278/1/src/kudu/integration-tests/raft_consensus-itest-base.h@27 PS1, Line 27: namespace kudu { > warning: using declarations in the global namespace in headers are prohibit Done http://gerrit.cloudera.org:8080/#/c/8278/1/src/kudu/integration-tests/raft_consensus-itest-base.h@28 PS1, Line 28: namespace tserver { > warning: using declarations in the global namespace in headers are prohibit Done http://gerrit.cloudera.org:8080/#/c/8278/1/src/kudu/integration-tests/raft_consensus-itest-base.cc File src/kudu/integration-tests/raft_consensus-itest-base.cc: http://gerrit.cloudera.org:8080/#/c/8278/1/src/kudu/integration-tests/raft_consensus-itest-base.cc@243 PS1, Line 243: // TODO(unknown): would be nice to be able to poll the leader with an RPC like > warning: missing username/bug in TODO [google-readability-todo] Done -- To view, visit http://gerrit.cloudera.org:8080/8278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5289b3de097f9a2ca152034fa2635b67ccddb93 Gerrit-Change-Number: 8278 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sun, 15 Oct 2017 02:54:24 +0000 Gerrit-HasComments: Yes
