Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8278 )
Change subject: [raft_consensus-itest] separate Raft election tests ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8278/5/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: http://gerrit.cloudera.org:8080/#/c/8278/5/src/kudu/integration-tests/raft_consensus-itest.cc@853 PS5, Line 853: string RaftConsensusITest::DumpToString(TServerDetails* leader, I'm curious why you chose to intersperse the test fixture's methods in with the tests themselves? Why not have the fixture methods defined right after the fixture's declaration? -- To view, visit http://gerrit.cloudera.org:8080/8278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5289b3de097f9a2ca152034fa2635b67ccddb93 Gerrit-Change-Number: 8278 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 16 Oct 2017 19:54:49 +0000 Gerrit-HasComments: Yes
