Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8276 )
Change subject: once: report init_succeeded instead of initted ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/fs/fs-test-util.h File src/kudu/fs/fs-test-util.h: http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/fs/fs-test-util.h@93 PS1, Line 93: Status CorruptBlock(FsManager* fs_manager, const BlockId in_id, > warning: function 'CorruptBlock' defined in a header file; function definit Done http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/fs/fs-test-util.h@94 PS1, Line 94: const uint64_t corrupt_offset, uint8_t flip_bit, BlockId* out_id) { > The name CorruptBlock suggests that it corrupts an existing block, but the Done http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/tserver/tablet_server-test.cc@51 PS1, Line 51: #include "kudu/fs/fs.pb.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/tserver/tablet_server-test.cc@104 PS1, Line 104: using kudu::fs::ReadableBlock; > warning: using decl 'ReadableBlock' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/tserver/tablet_server-test.cc@105 PS1, Line 105: using kudu::pb_util::ReadPBFromPath; > warning: using decl 'ReadPBFromPath' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/tserver/tablet_server-test.cc@108 PS1, Line 108: using kudu::pb_util::WritePBToPath; > warning: using decl 'WritePBToPath' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/tserver/tablet_server-test.cc@116 PS1, Line 116: using std::set; > warning: using decl 'set' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/tserver/tablet_server-test.cc@1240 PS1, Line 1240: req.set_batch_size_bytes(0); // so it won't return data right away > Why is this important? It's not, will take it out. Included it as a part of some initial testing. http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/util/once.h File src/kudu/util/once.h: http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/util/once.h@52 PS1, Line 52: // More versatile version of GoogleOnceDynamic, including the following: > Would you mind rewriting the block comment to describe the once semantics a Done http://gerrit.cloudera.org:8080/#/c/8276/1/src/kudu/util/once.h@101 PS1, Line 101: friend void internal::InitCb(void* arg); > warning: redundant 'InitCb' declaration [readability-redundant-declaration] Ignoring this. -- To view, visit http://gerrit.cloudera.org:8080/8276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ac7131144392d673e0a72a1ba9920bcf9fd991c Gerrit-Change-Number: 8276 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 16 Oct 2017 22:56:28 +0000 Gerrit-HasComments: Yes
