Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8276 )
Change subject: once: report init_succeeded instead of initted ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8276/4/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8276/4/src/kudu/tserver/tablet_server-test.cc@1208 PS4, Line 1208: unique_ptr<RowSetDataPB> rowset_pb(new RowSetDataPB()); is this variable used? seems like it's shadowed in the loop below http://gerrit.cloudera.org:8080/#/c/8276/4/src/kudu/tserver/tablet_server-test.cc@1248 PS4, Line 1248: ASSERT_TRUE(resp.has_error()); can you assert more specifically on the error string here? eg an ASSERT_STR_CONTAINS? -- To view, visit http://gerrit.cloudera.org:8080/8276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ac7131144392d673e0a72a1ba9920bcf9fd991c Gerrit-Change-Number: 8276 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 17 Oct 2017 04:45:18 +0000 Gerrit-HasComments: Yes
