Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8290 )
Change subject: fs: adjust directory sync behavior ...................................................................... fs: adjust directory sync behavior This patch centralizes the synchronization of fs roots and data directories in a new env_util helper method, which uses the set of all created files and directories as input to synchronization. There are a few related fixes: - DataDirManager::Create wasn't considering enable_data_block_fsync when synchronizing. It does now. - It was also synchronizing the directories themselves instead of their parent directories; the latter is what's needed for durability. Change-Id: I27e7bf6a5a31720cf80a002c3553536ee0975758 Reviewed-on: http://gerrit.cloudera.org:8080/8290 Reviewed-by: Andrew Wong <aw...@cloudera.com> Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/fs_manager.cc M src/kudu/util/env_util.cc M src/kudu/util/env_util.h 4 files changed, 36 insertions(+), 17 deletions(-) Approvals: Andrew Wong: Looks good to me, but someone else must approve Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I27e7bf6a5a31720cf80a002c3553536ee0975758 Gerrit-Change-Number: 8290 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
