Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 )
Change subject: KUDU-2191 (2/n): Hive Metastore client ...................................................................... Patch Set 30: (4 comments) http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/hms_client-test.cc File src/kudu/hms/hms_client-test.cc: http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/hms_client-test.cc@25 PS29, Line 25: #include <glog/stl_logging.h> : #include <gtest/gtest.h> > I think IWYU is right about removing these; I don't see any LOG/VLOG usage stl_logging.h is necessary for the stream formatting on line 194. I'll remove glog/logging.h. http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/hms_client.h File src/kudu/hms/hms_client.h: http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/hms_client.h@22 PS29, Line 22: #include <vector> > Maybe IWYU wants to remove this because: perhaps, but I don't think I should remove it. http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/hms_client.cc File src/kudu/hms/hms_client.cc: http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/hms_client.cc@26 PS29, Line 26: > Indeed, it seems IWYU is confused, and I cannot see why this happens. Done http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/mini_hms.h File src/kudu/hms/mini_hms.h: http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/mini_hms.h@30 PS29, Line 30: #include "kudu/util/subprocess.h" > IWYU's recommendation to remove this makes sense: you can forward declare S unique_ptr doesn't work with forward declared classes. -- To view, visit http://gerrit.cloudera.org:8080/7053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee Gerrit-Change-Number: 7053 Gerrit-PatchSet: 30 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 23 Oct 2017 14:05:41 +0000 Gerrit-HasComments: Yes
