Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 )
Change subject: KUDU-2191 (2/n): Hive Metastore client ...................................................................... Patch Set 29: (3 comments) http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/7053/29/src/kudu/hms/mini_hms.cc@121 PS29, Line 121: return WaitForTcpBind(hms_process_->pid(), &port_, MonoDelta::FromSeconds(20)); Any particular reason this timeout shouldn't be ridiculously high? Like, 90s? Do we have any tests that need to wait for it to fully elapse? http://gerrit.cloudera.org:8080/#/c/7053/22/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/7053/22/thirdparty/vars.sh@212 PS22, Line 212: BISON_NAME=bison-$BISON_VERSION > It's a SHA from the upstream Apache git repository. Can we not assume cont Every other commit hash in this file also includes a link to a repository, no matter how trivially accessible. I don't see why we should make an exception for Hive (or Thrift) when it's so easy to add a one line URL to the comment. Put another way, can you justify these exceptions, or explain why adding these URLs doesn't sit with you? http://gerrit.cloudera.org:8080/#/c/7053/26/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/7053/26/thirdparty/vars.sh@203 PS26, Line 203: # TODO(dan): bump to 0.11 when it's released. We chose to use a bleeding edge > The Apache project page is linked to in the license file. The apache git r You could link to the github mirror: https://github.com/apache/thrift. That would be fine too. -- To view, visit http://gerrit.cloudera.org:8080/7053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee Gerrit-Change-Number: 7053 Gerrit-PatchSet: 29 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Oct 2017 17:48:50 +0000 Gerrit-HasComments: Yes
