Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8314 )
Change subject: java: improve javadoc for setRangePartitionColumns ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8314/2/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java: http://gerrit.cloudera.org:8080/#/c/8314/2/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@90 PS2, Line 90: by : * default a table will be created with a range partitioned by the columns : * set in the hash partition, along with partition unbounded It will default to the PK columns, not the hash columns. I think this will read better as: 'If not set, the table is range partitioned by the primary key columns with a single unbounded partition.' -- To view, visit http://gerrit.cloudera.org:8080/8314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa41aa26bf1961f27a08a42a8353098d04305b6 Gerrit-Change-Number: 8314 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Camarena <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 23 Oct 2017 14:13:12 +0000 Gerrit-HasComments: Yes
