Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8314 )
Change subject: If not set, range partition does not default to no range partition Adding clarification to setRangePartitionColumns documentation, stating that if not set, by default the range will be partitioned by the columns set in the hash partition parameters, along ...................................................................... Patch Set 1: (1 comment) Dan, do you mind taking a look at this and make sure the new comment is accurate? http://gerrit.cloudera.org:8080/#/c/8314/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8314/1//COMMIT_MSG@7 PS1, Line 7: If not set, range partition does not default to no range partition Can you please update the commit message to follow the usual format with a one-line description, followed by a blank line, followed by this paragraph that you wrote here? https://chris.beams.io/posts/git-commit/ has some hints (this ensures that the commit shows up nicely in output like git log --oneline) A suitable one-liner description for this might be something like "java: improve javadoc for setRangePartitionColumns' -- To view, visit http://gerrit.cloudera.org:8080/8314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa41aa26bf1961f27a08a42a8353098d04305b6 Gerrit-Change-Number: 8314 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Camarena <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 18 Oct 2017 19:36:58 +0000 Gerrit-HasComments: Yes
