Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8304 )
Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8304/6/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/8304/6/src/kudu/mini-cluster/external_mini_cluster.h@138 PS6, Line 138: // If true, set up a Hive Metastore as part of this ExternalMiniCluster. > It's not so simple due to cases like data_root, block_manager_type, or daem sure, that makes sense. but for the ones that are simple bools like this it seems like it might be more readable. -- To view, visit http://gerrit.cloudera.org:8080/8304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1da05b13a120f2d4b739b6ab709e6315c955c0 Gerrit-Change-Number: 8304 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 24 Oct 2017 17:43:20 +0000 Gerrit-HasComments: Yes
