Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8392 )
Change subject: KUDU-1961: enable ccache when using devtoolset-3 ...................................................................... KUDU-1961: enable ccache when using devtoolset-3 The original approach outlined in the bug report doesn't work because although /opt/rh/devtoolset-3/ is ahead of /usr/bin during enable_devtoolset.sh, it isn't when make is invoked, so ccache ends up using the old system compiler and the build fails. So here's a more complicated approach: set CC/CXX to explicit ccache "helper" scripts, in the style of those found in build-support/ccache-clang. We do nothing if CC or CXX are already set; presumably the user knows better than us. In this manner, ccache is used by default in almost all cases. To opt out, set CCACHE_DISABLE in the environment when running make. Change-Id: Ic3a264fc9471e6486a3f17475697f1fa7b64a943 Reviewed-on: http://gerrit.cloudera.org:8080/8392 Tested-by: Adar Dembo <[email protected]> Reviewed-by: Todd Lipcon <[email protected]> --- A build-support/ccache-devtoolset-3/c++ A build-support/ccache-devtoolset-3/cc M build-support/enable_devtoolset.sh A build-support/enable_devtoolset_inner.sh 4 files changed, 84 insertions(+), 4 deletions(-) Approvals: Adar Dembo: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic3a264fc9471e6486a3f17475697f1fa7b64a943 Gerrit-Change-Number: 8392 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
