Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8392 )
Change subject: KUDU-1961: enable ccache when using devtoolset-3 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8392/1/build-support/enable_devtoolset_inner.sh File build-support/enable_devtoolset_inner.sh: http://gerrit.cloudera.org:8080/#/c/8392/1/build-support/enable_devtoolset_inner.sh@30 PS1, Line 30: export CC="$ROOT/ccache-devtoolset-3/cc" hrm.. the enable_devtoolset.sh wrapper seems to support any version of devtoolset (eg devtoolset-6 to get a newer GCC on el7) but this is specific to devtoolset-3. Is it possible to be more version-agnostic here, maybe by having enable_devtoolset set some env like $DEVTOOLSET_DIR or something? -- To view, visit http://gerrit.cloudera.org:8080/8392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3a264fc9471e6486a3f17475697f1fa7b64a943 Gerrit-Change-Number: 8392 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2017 20:42:47 +0000 Gerrit-HasComments: Yes
