Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 )
Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8376/2/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/8376/2/src/kudu/tablet/tablet_metadata.cc@440 PS2, Line 440: DeleteOrphanedBlocks(orphaned_blocks); > I think we discussed this elsewhere, but I"m concerned about this interacti pondering this a bit more, I wonder whether we need to actually start storing a separate "orphaned blocks" list for each data dir -- that way when we delete the failed tablet we can safely just delete the blocks that are known to be on the remaining disks? Alternatively we could feed the orphaned-blocks list from each tablet into the LBM at startup time to ensure that we don't reuse block IDs, but that's getting into relatively complex layer-crossing territory -- To view, visit http://gerrit.cloudera.org:8080/8376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e8d5697c2bb08287cce11fbdab6fb8d6e37d1ad Gerrit-Change-Number: 8376 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 27 Oct 2017 00:08:46 +0000 Gerrit-HasComments: Yes
