Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8407
to look at the new patch set (#3).
Change subject: [build] fixed OPENSSL_ROOT_DIR override on RH/CentOS
......................................................................
[build] fixed OPENSSL_ROOT_DIR override on RH/CentOS
For some reason, even if -DOPENSSL_ROOT_DIR=... was specified for
cmake invocation, the OpenSSL location was not overridden on
RedHat/CentOS machines where the OpenSSL 'workaround build' existed
in $KUDU_ROOT/thirdparty/installed/openssl-el6-workaround.
I also tried to modify the condition to be
if ((NOT "${OPENSSL_ROOT_DIR}") AND EXISTS "${CENTOS_6_4_OPENSSL_DIR}")
...
endif()
but it didn't help.
FWIW, it seems to contradict with the treatment of empty strings as
described at
https://cmake.org/cmake/help/v3.0/command/if.html
Anyway, I decided to test the OPENSSL_ROOT_DIR value using STREQUAL
and it fixed the issue, at least with cmake 3.9.0.
Change-Id: Ibe69b5d62ef4054e60138a154a85569d92166aff
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/8407/3
--
To view, visit http://gerrit.cloudera.org:8080/8407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe69b5d62ef4054e60138a154a85569d92166aff
Gerrit-Change-Number: 8407
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
