Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8229 )
Change subject: Add log parser script ...................................................................... Patch Set 1: (3 comments) Thanks for taking a look at this, Andrew! http://gerrit.cloudera.org:8080/#/c/8229/1/src/kudu/scripts/kudu-log-parser.pl File src/kudu/scripts/kudu-log-parser.pl: http://gerrit.cloudera.org:8080/#/c/8229/1/src/kudu/scripts/kudu-log-parser.pl@5 PS1, Line 5: # Pass it a list of logs from a whole cluster. > For the perl-uninitiated, maybe a sample shell line? There is a usage message that gets printed if the script is run without arguments. I'll note that here. http://gerrit.cloudera.org:8080/#/c/8229/1/src/kudu/scripts/kudu-log-parser.pl@39 PS1, Line 39: (?:leader )?((?:pre-)? > I think this matches "leader pre-election", "leader election", and "pre-ele Yes. Unfortunately, both "leader election" and "pre-election" occur: I0926 11:18:02.670809 23512 raft_consensus.cc:412] T ad3b9d7c7706426a8d881bac74a4f7a6 P a283d70a0bfb4ef8a324e4f0893bfa2d [term 42314 FOLLOWER]: Starting pre-election (detected failure of leader b80b06235d304dad93ada855a442e051) I0926 11:18:02.750224 7163 raft_consensus.cc:412] T 1f96edff8a964101bfe31a68f3c325ef P a283d70a0bfb4ef8a324e4f0893bfa2d [term 23380 FOLLOWER]: Starting leader election (detected failure of leader b80b06235d304dad93ada855a442e051) Ah, interesting catch on the forced leader election. I'll add that. http://gerrit.cloudera.org:8080/#/c/8229/1/src/kudu/scripts/kudu-log-parser.pl@236 PS1, Line 236: entry > nit: I'm having some trouble parsing out what an "entry" is vs what a "reco Sure, will do. -- To view, visit http://gerrit.cloudera.org:8080/8229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bd8bb5d9a3c598ade7bc1bbc8f5a9e24ca618af Gerrit-Change-Number: 8229 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 31 Oct 2017 18:29:49 +0000 Gerrit-HasComments: Yes
