Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8437 )
Change subject: fs: store opts at construction time ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8437/1/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/8437/1/src/kudu/fs/fs_manager.cc@333 PS1, Line 333: canonicalized_data_fs_roots_, std::move(dm_opts), &dd_manager_)); > But it's not actually accessing dm_opts after the move, is it? The LOG_TIMI right, but clang-tidy isn't smart enough to analyze the loop and know that it always only runs for one iteration. I'll see if I can come up with a non-looping variant for LOG_TIMING perhaps -- To view, visit http://gerrit.cloudera.org:8080/8437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If64ec78f28b5c6879805a682e209d96846f03f27 Gerrit-Change-Number: 8437 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 04:32:58 +0000 Gerrit-HasComments: Yes
