Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/5905 )
Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5905/4/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/5905/4/src/kudu/rpc/connection.cc@408 PS4, Line 408: OutboundTransfer* t = OutboundTransfer::CreateForCallResponse(slices, cb); > please leave some comment about the lifetime and ownership of 't' done. also removed the comment above which should have been removed in an earlier commit (it no longer applies to this code here) -- To view, visit http://gerrit.cloudera.org:8080/5905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d4d5f14fb302196b1797c712b21cfce81f157c1 Gerrit-Change-Number: 5905 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 03 Nov 2017 00:14:08 +0000 Gerrit-HasComments: Yes
