Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8458 )
Change subject: Revert "KUDU-2191 (2/n): Hive Metastore client" ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8458/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8458/2//COMMIT_MSG@18 PS2, Line 18: at least "1.7" (found /opt/toolchain/sun-jdk-64bit-1.6.0.31/bin/java) hrm, haven't we required java7 for quite a long time now? http://gerrit.cloudera.org:8080/#/c/8458/2//COMMIT_MSG@22 PS2, Line 22: Unknown CMake command "add_jar". Does the build in question define -DNO_TESTS? It seems like it's a bug that the include(UseJava) is wrapped in a 'if(NOT NO_TESTS)' but the add_jar in kudu/hms/CMakeLists.txt is not wrapped in it. i.e I'm not sure this is a cmake version issue -- To view, visit http://gerrit.cloudera.org:8080/8458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bbf7da48efa9618ebab3a1ca549790f96e59b11 Gerrit-Change-Number: 8458 Gerrit-PatchSet: 2 Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 03 Nov 2017 18:00:52 +0000 Gerrit-HasComments: Yes
