Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 )
Change subject: tablet: check for stopped in drivers of IO ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/8441/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8441/4//COMMIT_MSG@15 PS4, Line 15: before returning, it : must again check that the tablet has been stopped per comment in the code, not sure why you have to check on the way out in the success case? http://gerrit.cloudera.org:8080/#/c/8441/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/8441/4/src/kudu/tablet/tablet.cc@293 PS4, Line 293: return CheckActiveState(); it strikes me as odd here (and a few places below) that you are calling CheckActiveState on the way out of the success-path of these functions. I would expect that if I got an error here that it wouldn't have transitioned to a new state http://gerrit.cloudera.org:8080/#/c/8441/4/src/kudu/tablet/tablet.cc@369 PS4, Line 369: return CheckActiveState(); same here - this check is already racy, right? http://gerrit.cloudera.org:8080/#/c/8441/4/src/kudu/tablet/tablet.cc@957 PS4, Line 957: return CheckActiveState(); same, not sure of the point of doing these on the way out and not just on the way in -- To view, visit http://gerrit.cloudera.org:8080/8441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0241cd4206ce77ef1fb334458b091bc2092f4141 Gerrit-Change-Number: 8441 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 14 Nov 2017 00:42:36 +0000 Gerrit-HasComments: Yes
