Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8559 )
Change subject: [java] Add ReplicaSelection in KuduScanToken ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8559/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8559/1//COMMIT_MSG@10 PS1, Line 10: propagting propagating http://gerrit.cloudera.org:8080/#/c/8559/1/java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java File java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java: http://gerrit.cloudera.org:8080/#/c/8559/1/java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java@47 PS1, Line 47: Common.ReplicaSelection pbVersion() { Is this used anywhere? I'm nervous about adding this field, since it may be an ABI breaking change (https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html#jls-13.4.26 isn't very specific). http://gerrit.cloudera.org:8080/#/c/8559/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8559/1/src/kudu/common/common.proto@235 PS1, Line 235: enum ReplicaSelection { Add an 'UNKNOWN = 0;' variant. That's a protobuf best-practice. -- To view, visit http://gerrit.cloudera.org:8080/8559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914 Gerrit-Change-Number: 8559 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 16 Nov 2017 19:37:45 +0000 Gerrit-HasComments: Yes
