Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8559 )
Change subject: [java] Add ReplicaSelection in KuduScanToken ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8559/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8559/1//COMMIT_MSG@10 PS1, Line 10: propagatin > propagating Done http://gerrit.cloudera.org:8080/#/c/8559/1/java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java File java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java: http://gerrit.cloudera.org:8080/#/c/8559/1/java/kudu-client/src/main/java/org/apache/kudu/client/ReplicaSelection.java@47 PS1, Line 47: > Is this used anywhere? I'm nervous about adding this field, since it may b Done http://gerrit.cloudera.org:8080/#/c/8559/1/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/8559/1/src/kudu/common/common.proto@235 PS1, Line 235: enum ReplicaSelection { > Add an 'UNKNOWN = 0;' variant. That's a protobuf best-practice. Done -- To view, visit http://gerrit.cloudera.org:8080/8559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I860fcc73e486642ab5177cfd0dc0bdc98fdc6914 Gerrit-Change-Number: 8559 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 17 Nov 2017 00:04:09 +0000 Gerrit-HasComments: Yes
