Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7654 )
Change subject: handle disk failures during tablet copies ...................................................................... Patch Set 6: (4 comments) Some of these changes make sense but see my comments about Abort() http://gerrit.cloudera.org:8080/#/c/7654/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/7654/6//COMMIT_MSG@16 PS6, Line 16: WALs WAL segment http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/tablet_copy_source_session.cc File src/kudu/tserver/tablet_copy_source_session.cc: http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/tablet_copy_source_session.cc@133 PS6, Line 133: nullptr nit: since this is an optional out-param of the function, defaulting it to nullptr in the header file might be the user-friendlier option. Otherwise, would be helpful to add a comment to document what this is, like: RETURN_NOT_OK(CheckHealthyDirGroup(/*error_code=*/ nullptr)); http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/ts_tablet_manager.cc@694 PS6, Line 694: // In case of failure, shutdown the replica. : auto failure_cleanup = MakeScopedCleanup([&] { : replica->SetError(s); : replica->Shutdown(); : }); There is no need for this; the TabletCopyClient destructor will run Abort() and tombstone the replica if it didn't succeed. http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/ts_tablet_manager.cc@992 PS6, Line 992: / If the replica was marked failed while bootstrapping, abort. that should have already happened above on line 972, right? -- To view, visit http://gerrit.cloudera.org:8080/7654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic18d93c218ea13f3086f420a4847cb5e29a47bc7 Gerrit-Change-Number: 7654 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 21 Nov 2017 06:03:57 +0000 Gerrit-HasComments: Yes
