Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7654 )
Change subject: handle disk failures during tablet copies ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/7654/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/7654/6//COMMIT_MSG@16 PS6, Line 16: WAL > WAL segment Done http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/tablet_copy_source_session.cc File src/kudu/tserver/tablet_copy_source_session.cc: http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/tablet_copy_source_session.cc@133 PS6, Line 133: nullptr > nit: since this is an optional out-param of the function, defaulting it to Done with default http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/ts_tablet_manager.cc@694 PS6, Line 694: Status s = tc_client.FetchAll(replica); : if (!s.ok()) { : LOG(WARNING) << LogPrefix(tablet_id) << "Tablet Copy: Unable to fetch data from remote peer " : << kSrcPeerInfo << ": " << s.ToString(); : r > There is no need for this; the TabletCopyClient destructor will run Abort() Done http://gerrit.cloudera.org:8080/#/c/7654/6/src/kudu/tserver/ts_tablet_manager.cc@992 PS6, Line 992: (elapsed_ms > FLAGS_tablet_start_warn_threshold_ms) { > that should have already happened above on line 972, right? Ah, this should be "while starting", although I think this change could be pushed to the "handle failures at runtime" patch, since only then can errors get set in the replica externally. -- To view, visit http://gerrit.cloudera.org:8080/7654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic18d93c218ea13f3086f420a4847cb5e29a47bc7 Gerrit-Change-Number: 7654 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 21 Nov 2017 18:17:49 +0000 Gerrit-HasComments: Yes
