Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 )
Change subject: tablet: mark delta tracker read-only on error ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/8605/5/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: http://gerrit.cloudera.org:8080/#/c/8605/5/src/kudu/tablet/delta_tracker.h@362 PS5, Line 362: // Exclusive lock that ensures that only one flush o > I think we'll forget what this means. Maybe we should just say that errors Done http://gerrit.cloudera.org:8080/#/c/8605/5/src/kudu/tablet/delta_tracker.h@363 PS5, Line 363: // at a time. Protects redo_delta_stores_ and undo_delta_stores_. > do we need a full status here? This will take 8 bytes up in the object size Done http://gerrit.cloudera.org:8080/#/c/8605/5/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/8605/5/src/kudu/tablet/delta_tracker.cc@726 PS5, Line 726: > do we still want to FATAL in the case of a non-disk-error here? otherwise i Yeah, makes sense, we wouldn't want a maintenance-thread-hog. http://gerrit.cloudera.org:8080/#/c/8605/5/src/kudu/tablet/delta_tracker.cc@730 PS5, Line 730: > LOG_WITH_PREFIX Done -- To view, visit http://gerrit.cloudera.org:8080/8605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib950048e9cd0929a10714ab1cc2bd829835afced Gerrit-Change-Number: 8605 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 09:25:07 +0000 Gerrit-HasComments: Yes
