Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8605 )
Change subject: tablet: mark delta tracker read-only on error ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8605/6/src/kudu/tablet/delta_tracker.cc File src/kudu/tablet/delta_tracker.cc: http://gerrit.cloudera.org:8080/#/c/8605/6/src/kudu/tablet/delta_tracker.cc@740 PS6, Line 740: CHECK(s.IsDiskFailure()); CHECK(s.IsDiskFailure()) << LogPrefix() << s.ToString(); Otherwise this could be pretty frustrating to debug in the field. -- To view, visit http://gerrit.cloudera.org:8080/8605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib950048e9cd0929a10714ab1cc2bd829835afced Gerrit-Change-Number: 8605 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 21 Nov 2017 20:14:37 +0000 Gerrit-HasComments: Yes
