Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 )
Change subject: consensus: Add gflag to enable 3-4-3 re-replication ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8626/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/8626/1/src/kudu/consensus/raft_consensus.cc@124 PS1, Line 124: DEFINE_bool(raft_rereplication_add_before_evict, false, : "When enabled, failed replicas will only be evicted after a " : "replacement has been added to the config."); > OK, I see. I don't like putting version numbers in for config flags because they often last long after the versions have meaning, but you make a good point. How about: raft_prepare_replacement_before_eviction This is something that is actually new, and that would apply to many future designs, and represents something we're not doing that causes availability problems today. -- To view, visit http://gerrit.cloudera.org:8080/8626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I247842af7d0172d6e6b167a29613f6b261990a01 Gerrit-Change-Number: 8626 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 22 Nov 2017 00:44:41 +0000 Gerrit-HasComments: Yes
