Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8626 )
Change subject: consensus: Add gflag to enable improved re-replication ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8626/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/8626/1/src/kudu/consensus/raft_consensus.cc@124 PS1, Line 124: DEFINE_bool(raft_prepare_replacement_before_eviction, false, : "When enabled, failed replicas will only be evicted after a " : "replacement has been prepared for them."); > I meant to mention that this flag in case of the kudu-master binary means t After some consideration, I think we can leave this as it is. Perhaps, my confusion comes from that 'raft_' prefix and my perception that for master 'raft_' should be related to the Raft cluster of the system tablet. If we never want to control the latter by this flag, probably it's fine to keep this flag in here and give it a special treatment in case of catalog_manager. -- To view, visit http://gerrit.cloudera.org:8080/8626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I247842af7d0172d6e6b167a29613f6b261990a01 Gerrit-Change-Number: 8626 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 22 Nov 2017 19:35:20 +0000 Gerrit-HasComments: Yes
