Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8681 )
Change subject: KUDU-1097: Implement a "safe eviction" policy ...................................................................... Patch Set 2: (2 comments) > Uploaded patch set 2: Patch Set 1 was rebased. I'm not sure we need this sort of logic in the new scheme: what particular use case does it address? The only issue I see with the current logic is to allow evicting failed non-voters, so we would not end up with dead non-voters in all possible new locations. http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG@9 PS2, Line 9: We should respect the same kinds of policies for 3-4-3 eviction as we : use for 3-2-3 eviction as implemented in the SafeToEvict() function Why? What sort of issue do you try to address with that? http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG@11 PS2, Line 11: Specifically, we should only evict a node (voter or otherwise) if we are : reasonably confident that the resulting configuration can be committed : by enough healthy voters to form a majority. It's already so in the current code. Actually, there is a stronger condition now -- the number of healthy voter replicas should be not less than the replication factor. -- To view, visit http://gerrit.cloudera.org:8080/8681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 Gerrit-Change-Number: 8681 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 29 Nov 2017 20:15:52 +0000 Gerrit-HasComments: Yes
