Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8681 )
Change subject: KUDU-1097: Implement a "safe eviction" policy ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8681/2/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/8681/2/src/kudu/consensus/quorum_util-test.cc@493 PS2, Line 493: EXPECT_TRUE(CanEvictReplica(config, "A", 3, &uuid_to_evict)); : EXPECT_EQ("D", uuid_to_evict); I don't think this make sense. The replica C might be actually failed, and evicting a non-voter in good health (especially if it's in almost-caught-up state) is counter-productive in such a situation. -- To view, visit http://gerrit.cloudera.org:8080/8681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 Gerrit-Change-Number: 8681 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 29 Nov 2017 20:23:03 +0000 Gerrit-HasComments: Yes
