Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8868 )
Change subject: consensus: Fix NON_VOTER ack-counting bug ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.h@139 PS1, Line 139: const std::string > const std::string& ? Done http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.h@509 PS1, Line 509: const Status& status); > Please add a note into the inline doc describing the 'replica_types' parame Done http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/8868/1/src/kudu/consensus/consensus_queue.cc@228 PS1, Line 228: LOG_WITH_PREFIX_UNLOCKED(INFO) << "Queue going to NON_LEADER mode. S > nit: maybe, it's worth move this and related changes into a separate change Unfortunately, it's hard to do this and make it work, unless we split this into a CR that comes in before the fix, but it seems more useful to me in-context. -- To view, visit http://gerrit.cloudera.org:8080/8868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13143e9bb4b76af3fd6dada28fcec05b27d24476 Gerrit-Change-Number: 8868 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 19 Dec 2017 02:46:01 +0000 Gerrit-HasComments: Yes
