Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8869 )
Change subject: KUDU-2231: sparse column predicate can cause excessive data-block reads ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/8869/3/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: http://gerrit.cloudera.org:8080/#/c/8869/3/src/kudu/cfile/cfile_reader.cc@691 PS3, Line 691: return Status::NotSupported("no positional index in file"); > Done. You are right that SeekToPositionInBlock should be called in both cas Yea, this code is old enough that I don't really recall the finer details either. http://gerrit.cloudera.org:8080/#/c/8869/3/src/kudu/cfile/cfile_reader.cc@705 PS3, Line 705: // block in the file. > Not sure, you wrote that comment in 2012? Commit #14. I can remove it if Pretty sure the optimization you've just done is what I meant -- if you're already in the middle of a block, seeking to the same or later position in that block should not require reseeking the index. -- To view, visit http://gerrit.cloudera.org:8080/8869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8eb3be4a809f882ccd80c48612099b2071306ff7 Gerrit-Change-Number: 8869 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Dec 2017 05:15:07 +0000 Gerrit-HasComments: Yes
