Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8749 )
Change subject: KUDU-2232. java: Remove deprecated call from KuduTable ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8749/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/8749/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@223 PS2, Line 223: public List<String> getFormattedRangePartitions(long deadline) throws Exception { isn't this a breaking change, in that the deadline is now ignored? Don't we need to somehow pass the deadline into the KuduScanTokenBuilder or somesuch so that this doesn't change semantics? -- To view, visit http://gerrit.cloudera.org:8080/8749 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c54d0483241166675c65a8002464d4bd9604a4f Gerrit-Change-Number: 8749 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2018 22:33:04 +0000 Gerrit-HasComments: Yes
