Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8889 )
Change subject: [consensus] test-only option for replica replacement ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8889/2/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/8889/2/src/kudu/consensus/quorum_util-test.cc@957 PS2, Line 957: const auto kPolicies = { MHP_H, MHP_I } > so this is still repeated a bunch of times. can we put it at the top of the I decided to make it a parameterized test instead. -- To view, visit http://gerrit.cloudera.org:8080/8889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f89b6c584296e3da5047475c5c86c4cb1118ad0 Gerrit-Change-Number: 8889 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 05 Jan 2018 00:53:48 +0000 Gerrit-HasComments: Yes
