Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8889 )
Change subject: [consensus] test-only option for replica replacement ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8889/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8889/3//COMMIT_MSG@7 PS3, Line 7: [consensus] test-only option for replica replacement nit: how about titling this something a little more specific for the git log --online output, such as: [consensus] add unsafe gflag to bypass "safe to evict" logic http://gerrit.cloudera.org:8080/#/c/8889/3/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/8889/3/src/kudu/consensus/quorum_util-test.cc@a621 PS3, Line 621: it seems like a lot of code moved around in this patch. is that preventable? it makes the code review a lot more work. http://gerrit.cloudera.org:8080/#/c/8889/3/src/kudu/consensus/quorum_util.h File src/kudu/consensus/quorum_util.h: http://gerrit.cloudera.org:8080/#/c/8889/3/src/kudu/consensus/quorum_util.h@110 PS3, Line 110: //MajorityHealthPolicy policy = MajorityHealthPolicy::HONOR); remove? -- To view, visit http://gerrit.cloudera.org:8080/8889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f89b6c584296e3da5047475c5c86c4cb1118ad0 Gerrit-Change-Number: 8889 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Sat, 06 Jan 2018 00:23:46 +0000 Gerrit-HasComments: Yes
