Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8901 )
Change subject: [master/tserver] enforce re-replication scheme consistency ...................................................................... Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master.proto@338 PS4, Line 338: fields > field Done http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master.proto@340 PS4, Line 340: optional consensus.ReplicaManagementInfoPB replica_management_info = 10; > is this ever used? if not, let's drop it Good catch -- it seems this is just a left-over. http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master_service.cc@171 PS4, Line 171: $0 > ($0) Done http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master_service.cc@172 PS4, Line 172: $3 > ($3) Done http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master_service.cc@186 PS4, Line 186: return rpc->RespondSuccess(); > nit: how about It's two times more lines :) http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master_service.cc@194 PS4, Line 194: unknown > It's better to ignore tidy bot's warning than to add "unknown", IMHO. Done http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master_service.cc@195 PS4, Line 195: return rpc->RespondFailure(s); > nit: hmm, maybe this is personal preference but return x seems confusing in In C++ that's legal: it returns void from a function which has 'void' as a return type. All right -- I'll return back the two-line version. http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master_service.cc@258 PS4, Line 258: return rpc->RespondSuccess(); > nit: "return" at the end of a void function seems confusing and there is re This was an unification effort. All right, I'll remove this. http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/tserver/heartbeater.cc@460 PS4, Line 460: return StatusFromPB(error->status()); > nit: this repeats the line below. maybe just don't swap above, but copy? I resorted to return StatusFromPB(error ? error->status() : resp.error().status()); -- To view, visit http://gerrit.cloudera.org:8080/8901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71c4c2e72bb2d62cec6de0f6d00b418377e8ae85 Gerrit-Change-Number: 8901 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Jan 2018 23:35:15 +0000 Gerrit-HasComments: Yes
