Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8901 )
Change subject: [master/tserver] enforce re-replication scheme consistency ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/8901/4/src/kudu/master/master.proto@294 PS4, Line 294: optional consensus.ReplicaManagementInfoPB replica_management_info = 7; > I thought about the feature flag, but I decided to go with a field. After some consideration I decided to go with this approach. The reasoning: 1. The feature flags, introduced at this point, are not going to help with this particular feature since the older version don't know about would-be-introduced feature flags yet. 2. We have to propagate the same information to the Kudu CLI tool to allow automatic detection of the replica management scheme (see https://gerrit.cloudera.org/#/c/8915/), so there we re-use the consensus.ReplicaManagementInfoPB structure. If we want to have a feature flags here anyway, we can add those in a separate commit, after some quick design review. -- To view, visit http://gerrit.cloudera.org:8080/8901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71c4c2e72bb2d62cec6de0f6d00b418377e8ae85 Gerrit-Change-Number: 8901 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Jan 2018 23:50:40 +0000 Gerrit-HasComments: Yes
