Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8981 )

Change subject: [webui] Make tombstone tablet info less confusing
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc
File src/kudu/tserver/tserver_path_handlers.cc:

http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc@211
PS2, Line 211:   return 
replica->HumanReadableState().find("TABLET_DATA_TOMBSTONED") != string::npos;
> hrm, we can't get at this in a less stringy way?
Done


http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc@327
PS2, Line 327: Do not delete them
> think it would be nice to say something like "The tombstone markers are nec
Done



--
To view, visit http://gerrit.cloudera.org:8080/8981
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb
Gerrit-Change-Number: 8981
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Wed, 10 Jan 2018 20:33:18 +0000
Gerrit-HasComments: Yes

Reply via email to