Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8981 )
Change subject: [webui] Make tombstone tablet info less confusing ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc@211 PS2, Line 211: return replica->HumanReadableState().find("TABLET_DATA_TOMBSTONED") != string::npos; hrm, we can't get at this in a less stringy way? http://gerrit.cloudera.org:8080/#/c/8981/2/src/kudu/tserver/tserver_path_handlers.cc@327 PS2, Line 327: Do not delete them think it would be nice to say something like "The tombstone markers are necessary for correct operation of Kudu. These tablets have had all of their data removed from disk and do not consume significant resources, and must not be deleted." -- To view, visit http://gerrit.cloudera.org:8080/8981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c879cc7ff634e5b434fc33374d3010cf1f262cb Gerrit-Change-Number: 8981 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 10 Jan 2018 01:55:42 +0000 Gerrit-HasComments: Yes
