Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8982 )
Change subject: KUDU-2253 Deltafile on-disk size is 3x larger than expected ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8982/2/src/kudu/tablet/deltafile.cc File src/kudu/tablet/deltafile.cc: http://gerrit.cloudera.org:8080/#/c/8982/2/src/kudu/tablet/deltafile.cc@107 PS2, Line 107: opts.optimize_index_keys = false; did you consider putting the function in WriterOptions instead of a new parameter? http://gerrit.cloudera.org:8080/#/c/8982/2/src/kudu/tablet/deltafile.cc@109 PS2, Line 109: cfile::ValidxKeyEncoder key_encoder = [] (const void* value, faststring* buffer) { worth a comment here explaining why we can truncate the index and why we need the whole DeltaKey -- To view, visit http://gerrit.cloudera.org:8080/8982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cea3371fcf57f89fe10a3b9262bc152023cb04c Gerrit-Change-Number: 8982 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 12 Jan 2018 00:53:10 +0000 Gerrit-HasComments: Yes
