Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9021 )
Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/test_util.h@115 PS1, Line 115: // Do not use any back-off and loop every millisecond. nit: it doesn't check every millisecond, but rather sleeps one millisecond between checks (which might result in checking less frequently in the case that the checks themselves take some time) http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/threadpool-test.cc@934 PS1, Line 934: [](){} > o_O at least he didn't use the equivalent syntax <:]{%> http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/threadpool.cc@621 PS1, Line 621: auto cleanup = MakeScopedCleanup([&]() { can you use the SCOPED_CLEANUP macro instead if you don't need the named variable for cancellation purposes? -- To view, visit http://gerrit.cloudera.org:8080/9021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8036bf0d15f9ffcb3fa76579e3bfe0a340d38320 Gerrit-Change-Number: 9021 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2018 05:48:08 +0000 Gerrit-HasComments: Yes
