Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9029 )
Change subject: KUDU-2261: The order of the responses after flush should match the order we call apply ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/9029/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/9029/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@22 PS1, Line 22: import java.util.*; nit: we don't use wildcard imports http://gerrit.cloudera.org:8080/#/c/9029/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@383 PS1, Line 383: batchResponses.add(Deferred.fromResult(new BatchResponse(opsFailedInLookup, opsFailedIndexesList))); nit: please wrap http://gerrit.cloudera.org:8080/#/c/9029/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@485 PS1, Line 485: for ( int i = 0; i < indexList.size(); i++) { nit: extra space http://gerrit.cloudera.org:8080/#/c/9029/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@486 PS1, Line 486: responses[indexList.get(i)] = responseList.get(i); nit: can you add an assert like: int idx = indexList.get(i); assert responses[idx] == null; responses[idx] = responseList.get(i); http://gerrit.cloudera.org:8080/#/c/9029/1/java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java File java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java: http://gerrit.cloudera.org:8080/#/c/9029/1/java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java@46 PS1, Line 46: /** Holds indexes of operations. */ can you specify "in the original user's batch" -- To view, visit http://gerrit.cloudera.org:8080/9029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib37c9e85ad03731bb7d5b83be77d40fcd95e803a Gerrit-Change-Number: 9029 Gerrit-PatchSet: 1 Gerrit-Owner: zhen.zhang <zhangz...@xiaomi.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: zhen.zhang <zhangz...@xiaomi.com> Gerrit-Comment-Date: Wed, 17 Jan 2018 05:53:18 +0000 Gerrit-HasComments: Yes
