Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 )
Change subject: KUDU-2148: do not crash on GetStatus during server startup ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9041/1/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/9041/1/src/kudu/server/server_base.cc@522 PS1, Line 522: rpc > nit: RPC Done http://gerrit.cloudera.org:8080/#/c/9041/1/src/kudu/server/server_base.cc@525 PS1, Line 525: rpc > nit: RPC Done http://gerrit.cloudera.org:8080/#/c/9041/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/9041/2/src/kudu/tserver/tablet_server-test.cc@211 PS2, Line 211: controller.Reset(); > nit: maybe, just move RpcController under the scope of the 'while() {}' loo I appreciate the suggestion, but stylistically I prefer the "declare req, resp, and controller together" idiom we commonly use. http://gerrit.cloudera.org:8080/#/c/9041/2/src/kudu/tserver/tablet_server-test.cc@215 PS2, Line 215: CHECK(resp.has_status()); > nit: since there are many iterations of calling the GetStatus() method, may See above. http://gerrit.cloudera.org:8080/#/c/9041/2/src/kudu/tserver/tablet_server-test.cc@230 PS2, Line 230: ASSERT_OK(mini_server_->Restart()); > nit: consider adding some scope-related mechanics to join the thread if thi Done -- To view, visit http://gerrit.cloudera.org:8080/9041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b997999d8a1228244e0be0ea61705f2c12e3426 Gerrit-Change-Number: 9041 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 17 Jan 2018 22:37:16 +0000 Gerrit-HasComments: Yes
